fix: Return a file element even if the rendered list does not contained one #45121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper fix replacing #45031
When creating a file from a template we trigger a file action. This has a dependency on the file element
$el
that is used by some apps in <27 to get certain file attributes. Now while we wait for the file to be added to the file list, it might not be rendered if it is added at the end of the list outside the visible view.This PR addresses it by adding a fallback to return the rendered row in case we could not find the element in the DOM.
Onlyoffice is one example using this https://github.com/ONLYOFFICE/onlyoffice-nextcloud/blob/master/src/main.js#L212 but there are potentially others out there as well.
Steps to reproduce:
Error before the change